Hotfix to hide the external link badge from cards #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| }; | ||
| } | ||
|
|
||
| const isExternalLink = linkProperties.isLinkExternal ?? /^https?:\/\//.test(linkProperties.linkTo); | ||
| const isExternalLink = /^https?:\/\//.test(linkProperties.linkTo); |
There was a problem hiding this comment.
Ah yes! this is what we all needed. Thanks for thinking through this again 🙇
hanbyul-here
approved these changes
Oct 31, 2024
|
@dzole0311 if you created the 5.9.1 patch from here, could you update the package.json too to when it merges, it has the udpate version reflected? |
Merged
AliceR
added a commit
that referenced
this pull request
Nov 12, 2024
## 🎉 Features * Card image/description independent of hero image/description by @dzole0311 in #1244 ## 🚀 Improvements * Cookie consent code cleanup by @snmln in #1199 , and @hanbyul-here in #1240 , and @hanbyul-here in #1241 * Add ADR about design system change by @j08lue in #890 * Update condition to run playwright tests on release branches by @dzole0311 in #1228 * Update STYLE_GUIDE.md by @AliceR in #1227 * Fix lint configuration by @AliceR in #1219 * Add tests for the AOI feature specification by @AliceR in #1216 * Set data catalog filters to be closed by default by @vgeorge in #1243 * Update tsconfig and make nav interfaces exposable for consumption by @sandrahoang686 in #1223 ## 🐛 Fixes * Hotfix to hide the external link badge from cards by @dzole0311 in #1231 ## New Contributors * @vgeorge made their first contribution in #1243 **Full Changelog**: v5.9.0...v5.10.0
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: {link related ticket here}
Description of Changes
This update addresses a mistake I made from the initial fix involving the new
isExternalLinkprop, which unintentionally altered the behavior of external links. Basically, this prop not only hid the "External Link" badge but also incorrectly routed external links through React's internal routing, resulting in URLs likeearth.gov/visit/https://earth.gov/mobile-climate-mapperinstead of correctly navigating toearth.gov/mobile-climate-mapperWhat's fixed here:
isExternalLinkprop to revert unintended internal link behaviorhideExternalLinkBadgethat more clearly describes it's role and is used specifically for visually hiding the "External Link" badge without altering the link's external behaviorNotes & Questions About Changes
To minimize team effort for a hotfix release and since this fix is specific to the EIC instance only, I did the following:
Validation / Testing
hideExternalLinkBadgeprop to theExternal Link TeststoryOr check it out in practice on the EIC instance here, where the Mobile Climate Mapper card has no "External Link" badge anymore: